refactor: Refactor supernova module to avoid needless pass-by-value #28

huitseeker · 2023-08-27T17:33:53Z

Modified SuperNovaAugmentedCircuitParams to be passed by reference in test_recursive_circuit_with function and associated instances in test.rs.
Updated SuperNovaAugmentedCircuit::new method to match changes in the test_recursive_circuit_with function.
Revamped arguments handling in synthesize_non_base_case and synthesize functions in circuit.rs, changing from owned types to references to reduce unnecessary cloning.
Altered function body to accommodate the changes for referenced values in circuit.rs.

porcuquine

Looks good once CI passes. Consider merging #23 first then applying changes there for simplicity if this is still incomplete.

- Modified `SuperNovaAugmentedCircuitParams` to be passed by reference in `test_recursive_circuit_with` function and associated instances in `test.rs`. - Updated `SuperNovaAugmentedCircuit::new` method to match changes in the `test_recursive_circuit_with` function. - Revamped arguments handling in `synthesize_non_base_case` and `synthesize` functions in `circuit.rs`, changing from owned types to references to reduce unnecessary cloning. - Altered function body to accommodate the changes for referenced values in `circuit.rs`.

This backports the following Arecibo PRs: - #2 - #3 - #10 - #16 - #23 - #30 - #28 - #41 - #45 - #50 - #56 - #51 - #72 - #92 - #95 - #97 - #101 - #110 - #106 - #112 - #114 - #119 - #120 - #127 - #123 - #131 - #174 - #175 - #182 Co-authored-by: WYATT <[email protected]> Co-authored-by: Hanting Zhang <[email protected]> Co-authored-by: Ming <[email protected]> Co-authored-by: porcuquine <[email protected]> Co-authored-by: Samuel Burnham <[email protected]> Co-authored-by: Matej Penciak <[email protected]> Co-authored-by: Adrian Hamelink <[email protected]>

huitseeker requested a review from porcuquine August 27, 2023 17:33

huitseeker force-pushed the needless_pass_by_values branch from 0d8f67a to 1935059 Compare August 27, 2023 17:36

porcuquine previously approved these changes Aug 27, 2023

View reviewed changes

huitseeker dismissed porcuquine’s stale review via 012c58c August 27, 2023 17:57

huitseeker force-pushed the needless_pass_by_values branch from 1935059 to 012c58c Compare August 27, 2023 17:57

huitseeker enabled auto-merge August 27, 2023 17:57

porcuquine previously approved these changes Aug 27, 2023

View reviewed changes

huitseeker dismissed porcuquine’s stale review via 5ef7ea2 August 28, 2023 05:07

huitseeker force-pushed the needless_pass_by_values branch 2 times, most recently from 5ef7ea2 to a25bc5b Compare August 28, 2023 05:08

porcuquine previously approved these changes Aug 28, 2023

View reviewed changes

huitseeker added this pull request to the merge queue Aug 28, 2023

github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Aug 28, 2023

huitseeker dismissed porcuquine’s stale review via 5785b4b August 28, 2023 18:20

huitseeker force-pushed the needless_pass_by_values branch from a25bc5b to 5785b4b Compare August 28, 2023 18:20

huitseeker force-pushed the needless_pass_by_values branch from 5785b4b to caa1255 Compare August 28, 2023 18:34

porcuquine approved these changes Aug 28, 2023

View reviewed changes

huitseeker enabled auto-merge August 28, 2023 18:47

huitseeker added this pull request to the merge queue Aug 28, 2023

Merged via the queue into dev with commit b1f971b Aug 28, 2023

huitseeker deleted the needless_pass_by_values branch August 28, 2023 19:35

huitseeker added the supernova label Dec 17, 2023

huitseeker mentioned this pull request Dec 18, 2023

feat: implement SuperNova microsoft/Nova#283

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Refactor supernova module to avoid needless pass-by-value #28

refactor: Refactor supernova module to avoid needless pass-by-value #28

huitseeker commented Aug 27, 2023

porcuquine left a comment

refactor: Refactor supernova module to avoid needless pass-by-value #28

refactor: Refactor supernova module to avoid needless pass-by-value #28

Conversation

huitseeker commented Aug 27, 2023

porcuquine left a comment

Choose a reason for hiding this comment